Redesign extraction contract for grouped calls and readiness#618
Open
chetanr25 wants to merge 1 commit into
Open
Redesign extraction contract for grouped calls and readiness#618chetanr25 wants to merge 1 commit into
chetanr25 wants to merge 1 commit into
Conversation
…arallel field-group extraction into a draft incident row, plus a readiness endpoint, defaults block, and template_id validate. Issue fireform-core#617
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redesign extraction for grouped calls and readiness
Why
The incident contract is now too large for a single LLM pass to extract reliably, something discussion #609 flagged directly. Extraction also needed a real link to a stored incident and a way to tell the user which forms are ready before they hit a failed generate call.
What changed
defaultsblock (country, timezone, currency) to the extraction request so dates and money resolve correctly without relying on the model to infer them.GET /extract/{extract_id}/readiness, comparing the contract against every registered template and reporting which ones are ready to fill and what is missing for the rest. No LLM involved, cheap to call after every correction.FieldGapso a missing field comes with enough context (source, where the value should live) for the review screen to explain it properly.validatenow takes atemplate_idinstead of aform_type, matching the move to user-registered templates.custom_fields.Reference
Discussion: #609.
Related Issue: #617